Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MkInputをジェネリックコンポーネントにする #15345

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

fix: MkInputをジェネリックコンポーネントにする #15345

wants to merge 20 commits into from

Conversation

takejohn
Copy link
Contributor

@takejohn takejohn commented Jan 25, 2025 •
edited
Loading

What

  • MkInputをジェネリックコンポーネントにしてupdate:modelValueイベントの値の型がtypeプロパティに合うように変更
  • MkInputを使用してる箇所で省略されていたtype="text"を追加して型エラーを低減
  • Vue Test Utilsを導入
  • コンポーネントのテスト

Why

#15173 (comment) 関連

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jan 25, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.85%. Comparing base (a3d236c) to head (5a36657).
Report is 560 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff              @@
##           develop   #15345       +/-   ##
============================================
- Coverage    41.74%   19.85%   -21.89%     
============================================
  Files         1549      764      -785     
  Lines       196555   111048    -85507     
  Branches      2767     1302     -1465     
============================================
- Hits         82055    22053    -60002     
+ Misses      113939    88413    -25526     
- Partials       561      582       +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takejohn takejohn changed the title fix: AiScriptで用いられるコンポーネントの型エラー修正 fix: MkInputをジェネリックコンポーネントにする Jan 26, 2025
@takejohn takejohn marked this pull request as ready for review January 26, 2025 14:17
@tai-cha
Copy link
Contributor

tai-cha commented Jan 26, 2025

MkInputのtype属性に関してはwithDefaultsを使ってむしろデフォルトvalueをtextにしてしまう手もあると思うのですがどうでしょうか…？（現在と変わらない使い勝手で型エラーを減らせるはず、かつ同時並行で動いているPRが死なないと思うのですが）

@takejohn
Copy link
Contributor Author

MkInputのtype属性に関してはwithDefaultsを使ってむしろデフォルトvalueをtextにしてしまう手もあると思うのですがどうでしょうか…？（現在と変わらない使い勝手で型エラーを減らせるはず、かつ同時並行で動いているPRが死なないと思うのですが）

withDefaultsを使ってtypeを省略すると型は推論できないみたいですね……
ただ、typeを省略するとupdate:modelValueイベントの値の型は従来通りstring | numberになるので、
42fcdaa はrevertして型エラーが出るところだけ変更するようにします。

@takejohn takejohn marked this pull request as draft January 27, 2025 02:38
@takejohn takejohn marked this pull request as ready for review January 30, 2025 03:05
@takejohn
Copy link
Contributor Author

たぶんできた

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
packages/frontend Client side specific issue/PR
Projects
[実験中] 管理用
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takejohn @tai-cha